Merged 22
-
-
-
-
-
Issue #4934: Enforced WS in appropriate places for block javadoc tags
-
Issue #3810: Replaced singletonTag in nested html rules in javadoc gr…
…ammar with singletonElement
-
Issue #4390: Modified error handling of errors that are to be generat…
…ed when missing HTML tags are encountered while parsing javadoc
This was a significant performance upgrade for ANTLR javadoc parser. The code to recognize missing HTML tags was embedded inside the javadoc grammar but that was shooting up the complexity for javadoc parser. This was because almost identical, heavy and recursive production rules had been used to recognize the missing HTML tag making ANTLR work harder to resolve the related ambiguities.
-
Issue #4717: Added JavadocParserErrorStrategy which extends BailError…
…Strategy
Javadoc Parser is designed to bail out on the first parse error encountered. The thing was, though a sub class provided by ANTLR to achieve exactly this, it failed to properly report parse errors and this also happened to be the class the checkstyle code was using. So that ANTLR class was further extended and proper error reporting code was added to the new class.
-
Issue #4448: Updated token names and rule names in javadoc grammar in…
… accordance with the HTML specification
-
Issue #2329: Updated lexer grammar to allow javadoc with CR newlines
-
Issue #4405: Javadoc position to be checked before rendering ASTs
-
Issue #4381: Renamed all javadoc grammar tests' input files to have .…
…javadoc as extension
-
-
Issue #4381: Refactored Javadoc AST tests. They now use trees printed…
… by DetailNodeTreeStringPrinter to verify the javadoc grammar
The testing of the parse tree produced by ANTLR was previously done using a custom method generator hosted at checkstyle/contribution which resulted in thousands of lines of code and didn’t even give the developer any means to properly visualize the parse tree. Furthermore the final javadoc tree produced by checkstyle weren’t even properly covered with UTs. This update removed all such tests and tests symmetric to those were added and they verified the final javadoc parse tree directly.
-
Issue #4445: Verifying calls to private static method using powermock…
… was causing CI failures due to apparent conflict with cobertura
-
A UT whose need was realized whilst working on Issue #2329. It was eventually replaced in Issue #4381 with a similar test but one which asserted equivalence of the final javadoc tree `String` that is generated.
-
Issue #4393: ASTs to be generated and walked only when there are corr…
…esponding type of checks. No parsing if no checks are specified
-
Issue #4349: Changed the lexer grammar for javadoc to make package na…
…mes conform to the standard
Menu
Project details
Mentor: https://github.com/vladlis Second mentor: https://github.com/sabaka
Student: https://github.com/ps-sp
Project plan: https://docs.google.com/document/d/1daMZ96np7roEC5EavyK96ZYLrEXKXvFcleGur69nUY0/edit?usp=sharing
Mail-list discussion: https://groups.google.com/forum/?hl=en#!topic/checkstyle-devel/cRw80h4Q73o